Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCC output improvements #151

Merged
merged 4 commits into from
Nov 18, 2022
Merged

SCC output improvements #151

merged 4 commits into from
Nov 18, 2022

Conversation

mikouaj
Copy link
Member

@mikouaj mikouaj commented Nov 16, 2022

  • SCC findings use IDs based on hash from resourceName and category (rather than random IDs)
  • SCC findings are upserted with all mutable fields being replaced
  • coroutine logic was modified to align with inputs and k8s client
  • Added GPA version to SourceProperties of SCC finding

@mikouaj mikouaj added the enhancement New feature or request label Nov 16, 2022
@mikouaj mikouaj merged commit f6910e2 into main Nov 18, 2022
@mikouaj mikouaj deleted the scc-impr branch November 18, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewojtach ewojtach ewojtach approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikouaj @ewojtach